Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Projector: Permission change #1011

Closed
MSoeb opened this issue Aug 19, 2024 · 9 comments · Fixed by #1015
Closed

Projector: Permission change #1011

MSoeb opened this issue Aug 19, 2024 · 9 comments · Fixed by #1015
Labels
enhancement General enhancement which is neither bug nor feature high
Milestone

Comments

@MSoeb
Copy link

MSoeb commented Aug 19, 2024

Current behavior
Currently, with the group right “Can see the projector”, you can see the projector in the Autopilot and the menu item “Projector”. The last point is suboptimal, as A) the menu item potentially contains further administrative content that should not be publicly visible and B) the menu bar generally contains an item that offers no added value for following a meeting.

Wanted behavior
The group right 'Can see the projector' should only make the projector visible in Autopilot, no longer the menu item 'Projector'. The menu item should only be visible via the 'Can manage the projector' group right.

Important: The content currently projected onto the standard projector should still be visible in the Autopilot. No changes should be made in the Autopilot.

@MSoeb MSoeb added the enhancement General enhancement which is neither bug nor feature label Aug 19, 2024
@MSoeb MSoeb added this to the 4.2 milestone Aug 19, 2024
@bastianjoel
Copy link
Member

@MSoeb Please specify which information should not be visible to users without "Can manage the projector" permission. This infos should be restricted.

@rrenkert
Copy link
Member

Talked to @MSoeb:
Wanted behavior is:

  • The default projector should be visible in autopilot with "can see autopilot" permission
  • The menu entry and the projectors are visible with the "can see projector" permission
  • No changes are necessary for "can manage projector" permission

@rrenkert rrenkert added the high label Sep 9, 2024
@rrenkert rrenkert transferred this issue from OpenSlides/openslides-client Sep 10, 2024
@ostcar
Copy link
Member

ostcar commented Sep 10, 2024

@rrenkert when you say "default projector" you probably mean "reference projector"?
We have the fields used_as_reference_projector_meeting_id and we have fields used_as_default_projector_for_*_in_meeting_id

Are you sure, that only the projector has to be changed and not also the projection?

@ostcar ostcar linked a pull request Sep 10, 2024 that will close this issue
@bastianjoel
Copy link
Member

The projections also need to be changed.

@ostcar
Copy link
Member

ostcar commented Sep 11, 2024

The projections also need to be changed.

How should it change? The current rule is:

The user can see a projection, if the user has projector.can_see.

This means, even before this change, that a user could see a projection of a projector, when the projector was set to internal. Was this intended? If not, then I would propose, that a user can see a projection, if he can see the linked projector. This would mean, that a user with meeting.can_see_autopilot can see the projection on the reference projector, but to see projections on other projectors, you need projector.can_see. In the projector is internal, then you need projector.can_manage, and it does not mater, ifs the reference projector or not.

Is this ok?

@bastianjoel
Copy link
Member

Sounds good. The client only ever requests projections via projectors so this should not break anything.

@ostcar
Copy link
Member

ostcar commented Sep 11, 2024

There are this three fields: current_projector_id, preview_projector_id and history_projector_id.

I think a user with meeting.can_see_autopilot should only see the current projection of the reference projector. The same with projector.can_see with all non-internal projectors. To see a projection on a preview_projectors and history_projectors, you need projector.can_manage.

When I remember correctly, then the content field is only calculated for current projections. So the problem is not the content of a projection, but the other fields. I would guess, that only a projector-manager needs them. Could you confirm this?

I would propose, that a user can see a projection, if he has projector.can_manage or if he can see the projector linked in current_projector_id.

@bastianjoel
Copy link
Member

Yes, preview_projector_id and history_projector_id are only used for the projector detail view which is only accessible with projector.can_manage in the client.

@ostcar
Copy link
Member

ostcar commented Sep 11, 2024

Ok, I updated it accordingly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement General enhancement which is neither bug nor feature high
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants