Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SolrMatcherSupport configurability #5

Open
dsmiley opened this issue Jan 22, 2014 · 0 comments
Open

SolrMatcherSupport configurability #5

dsmiley opened this issue Jan 22, 2014 · 0 comments

Comments

@dsmiley
Copy link
Member

dsmiley commented Jan 22, 2014

SolrMatcherSupport's initialize() method currently examines global system properties to decide where it will find Solr. In general, global system properties can be handy but shouldn't be the only means of configuring things. There may be more than one Solr server being used, particularly in development (local indexing and remote gaz catalogs). This can be fixed by simply adding a setter for "solr", and then not overriding a non-null value in initialize(). Also, in the case that "solr.url" is set, it'd be better to concatenate the getCoreName() method's value to the url and with an extra '/' so that if I use a solr.url system property then I can have, say, both the "gazetteer" and "tax" cores and still use one solr.url set to http://..../solr/. Otherwise I can't use two SolrMatcherSupport's for remote'ed Solr.

@mubaldino mubaldino added this to the Xponents 3.6 milestone Jan 6, 2022
@mubaldino mubaldino removed this from the Xponents 3.6 milestone Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants