-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SolrJ extension for SolrTextTagger #52
Comments
Very cool! After we switch to Java 8 (which I see this code requires as it uses .stream()), what do you think of providing this code with the text tagger? It would probably result in another module but I think that's better than separate projects altogether. |
I should definitely be an own module (as it only depends on SolrJ and does not have a direct dependency to the SolrTextTagger module. I have no problem of managing it at the above location, but maybe SolrTextTagger user will more likely find it when it is made available under the same groupId as the Regarding Java 8: I was in the impression that Solr 6 requires Java 8. In SolrJ they renamed some of the main classes with Solr 6. So to support older Java versions one would need to provide two separate releases (one for SolrJ 6 and SolrJ 5) |
I just released 2.3 and bumped the tagger to Solr 6 and Java 8. Yes, Solr 6 requires Java 8. |
Now that Solr 7.4.0 includes the tagger, perhaps you might want to propose your addition directly to Apache Solr / SolrJ. |
Hi all,
Not really an issue, but I wanted to let you know that I implemented
SolrParams
,SolrRequest
andSolrResponse
specific for the SolrTextTagger.The module is available at https://github.com/redlink-gmbh/solrj-text-tagger/
I plan to make it available at Maven Central in the coming days.
Feedback welcome!
best
Westei
The text was updated successfully, but these errors were encountered: