Extend "os" section, adding other OS sub-attributes in opennebula_template

[sam-wouters]

Description

Currently only ARCH and BOOT sub-attributes are accepted in the os section, when trying to set other os sub-attributes using template_sections, this results in a change on every terraform plan.

New or affected resources and data sources

opennebula_template

Potential terraform configuration

os {
  arch = "x86°64"
  boot = ""
  firmware = "/usr/share/OVMF/OVMF_CODE.secboot.fd"
  firmware_secure = true
  machine = "q35" 
}

References

No response

[github-actions]

This issue is stale because it has been open for 30 days with no activity and it has not the 'status: confirmed' label or it is not in a milestone. Remove the 'status: stale' label or comment, or this will be closed in 5 days.

[jaypif]

Can we re open this issue as this is required to some VM with UEFI boot in the OS

thanks

[github-actions]

This issue is stale because it has been open for 30 days with no activity and it has not the 'status: confirmed' label or it is not in a milestone. Remove the 'status: stale' label or comment, or this will be closed in 5 days.

[jschoewe]

Why does this keep getting stale and closed? Some of us have templates that need secure boot enabled in order to boot them after they're cloned. The work looks done, these fields were added to the one GOCA 2 months ago:
OpenNebula/one#6795
OpenNebula/one#6782

That issue was closed and added to the latest enterprise release (6.10.2) a month ago:
https://github.com/OpenNebula/one/milestone/80?closed=1

I cloned the following branch from this provider, merged master into it, built the provider using this updated code, and tested it on Open Nebula 6.10.2:
#579

It works great, I also tested on an earlier version (6.10.0) and that still works too. These new fields aren't required, this PR doesn't contain breaking changes, building and using a forked provider is a pain, people have been waiting months for this, I don't see any reason not to merge it anymore.

Merge this now please!

 
Testing:

Open Nebula version:

Terraform apply result:

Cloned template new OS fields 6.10.2:

The OS fields for older versions will look like this and still work: