Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: Event for configuration actions (save/delete) on path #3977

Closed
pquerner opened this issue May 8, 2024 · 2 comments
Closed

Comments

@pquerner
Copy link
Contributor

pquerner commented May 8, 2024

Description (*)

In my opinion OpenMage could need a few new events around configuration alteration or deletion.
A general event such as core_config_data_delete_commit_after is already thrown, but maybe a core_config_data_delete_<xml_path> is more readable.

Expected behavior (*)

Add event so that a listener can be set on a specific xml_path. Or even specific value. (When XML Path changes from X to Y, or its new value is Z)

Benefits

For example, if you ever wanted to know that a specific path was changed for the system configuration, so that you can run an observer on it.

Additional information

Right now you may listen on core_config_data_delete_commit_after and the others, which kinda works but often adds boilerplate code to find out which xml path was changed. Or what the new value is (I think that info is even missing, aka old value <> new value)

@fballiano
Copy link
Contributor

If we have a PR I think we can accept that

@hirale
Copy link
Contributor

hirale commented May 8, 2024

some third-party modules like admin action logs have something similar

@OpenMage OpenMage locked and limited conversation to collaborators Oct 17, 2024
@addison74 addison74 converted this issue into discussion #4288 Oct 17, 2024

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Projects
None yet
Development

No branches or pull requests

4 participants