Skip to content

Commit 37e0446

Browse files
authored
Fix UI being unresponsive for up to 30seconds in really rare edge cases
This must have made it in while testing something out & forgetting to remove it, don't set the timeout to 10 seconds - with the default of 3 retransmissions (and each retransmission waits for timeout seconds) it can block the UI for up to 30seconds on operations that don't use async to update params (pretty much all).
1 parent 818d23a commit 37e0446

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

app/telemetry/settings/mavlinksettingsmodel.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -359,7 +359,7 @@ bool MavlinkSettingsModel::try_fetch_all_parameters()
359359
}
360360
qDebug()<<"Done removing old params";
361361
// now fetch all params using mavsdk (this talks to the OHD system(s).
362-
param_client->set_timeout(10);
362+
//param_client->set_timeout(10);
363363
const auto params=param_client->get_all_params(true);
364364
for(const auto& int_param:params.int_params){
365365
MavlinkSettingsModel::SettingData data{QString(int_param.name.c_str()),int_param.value};

0 commit comments

Comments
 (0)