Skip to content

Commit

Permalink
Fix UI being unresponsive for up to 30seconds in really rare edge cases
Browse files Browse the repository at this point in the history
This must have made it in while testing something out & forgetting to remove it, don't set the timeout to 10 seconds - with the default of 3 retransmissions (and each retransmission waits for timeout seconds) it can block the UI for up to 30seconds on operations that don't use async to update params (pretty much all).
  • Loading branch information
Consti10 authored Feb 3, 2023
1 parent 818d23a commit 37e0446
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion app/telemetry/settings/mavlinksettingsmodel.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -359,7 +359,7 @@ bool MavlinkSettingsModel::try_fetch_all_parameters()
}
qDebug()<<"Done removing old params";
// now fetch all params using mavsdk (this talks to the OHD system(s).
param_client->set_timeout(10);
//param_client->set_timeout(10);
const auto params=param_client->get_all_params(true);
for(const auto& int_param:params.int_params){
MavlinkSettingsModel::SettingData data{QString(int_param.name.c_str()),int_param.value};
Expand Down

0 comments on commit 37e0446

Please sign in to comment.