Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All time pickers can be set to UTC time #1813

Open
321github123 opened this issue Jan 7, 2025 · 10 comments · May be fixed by #1831
Open

All time pickers can be set to UTC time #1813

321github123 opened this issue Jan 7, 2025 · 10 comments · May be fixed by #1831
Assignees
Labels
question Questions about OpenC3

Comments

@321github123
Copy link

First check out our main documentation site at https://openc3.com.

Is your feature request related to a problem? Please describe.
Our users use UTC instead of local time

Describe the solution you'd like
A global flag sets time pickers to use UTC instead of local time s e.g. Data Viewer, Data Extractor, Command History etc

Additional context
Add any other context or screenshots about the feature request here.

@ryanmelt
Copy link
Member

ryanmelt commented Jan 7, 2025

This already exists in Admin -> Settings.
Is it not working somewhere?

@ryanmelt ryanmelt added the question Questions about OpenC3 label Jan 7, 2025
@321github123
Copy link
Author

Does the Admin -> Settings change how the times are interpreted? For example, will the times pickers in Data Extractor be now interpreted as UTC time vs local time if UTC is chosen in the Admin setting?

image

The help text in the Admin panel makes it seem that the Time Zone setting only affects the display of time.

image

@ryanmelt
Copy link
Member

ryanmelt commented Jan 8, 2025

It does only affect display on the frontend. Our api and the backend is always UTC for everything.

@321github123
Copy link
Author

ok that makes sense -- can we add a UTC label to the time pickers then?

@jmthomas
Copy link
Member

jmthomas commented Jan 8, 2025

Are you displaying the Astro Clock? The Astro Clock changes to UTC time which is present on all the tools.

@321github123
Copy link
Author

yes the Astro Clock is showing UTC -- I think the request would be to add a UTC label here (and all other time pickers) to be more explicit
image

@jmthomas
Copy link
Member

jmthomas commented Jan 8, 2025

We have a lot of time pickers throughout our application that would have to manually add the UTC notification so this is unlikely to get implemented unless directly driven by customer requirements. I don't see anything in AstroUX that indicates adding 'UTC' to time pickers. I feel like the Astro Clock is a clear indicator for what the time format is.

@321github123
Copy link
Author

I think the confusion stemmed from seeing the local time in the AstroClock (since that is the default) and not knowing all time pickers are actually UTC.

Maybe a compromise is to default to UTC time zone?

@jmthomas
Copy link
Member

jmthomas commented Jan 9, 2025

When the Admin Time Zone setting is set to UTC then the Astro Click and all the time pickers are UTC. When the Time Zone setting is set to local then all the time pickers are local. If certain applications / time pickers are not behaving this way please let me know.

@321github123
Copy link
Author

That's very helpful information. Maybe we could add that information (setting the time zone sets the time pickers's time zone) here?

image

@jmthomas jmthomas self-assigned this Jan 15, 2025
@jmthomas jmthomas linked a pull request Jan 15, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Questions about OpenC3
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants