Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integer Command Parameter with Write Conversion that takes a String Input #1825

Open
ryanmelt opened this issue Jan 14, 2025 · 0 comments · May be fixed by #1845
Open

Integer Command Parameter with Write Conversion that takes a String Input #1825

ryanmelt opened this issue Jan 14, 2025 · 0 comments · May be fixed by #1845
Assignees
@jmthomas
Labels
bug Something isn't working priority Priority issues driven by customers

Comments

@ryanmelt
Copy link
Member

The range on command parameters is meant to be in converted format (before conversion to raw format).
However, it doesn't actually work that way. At least for the configuraiton of an integer raw type, and a conversion that takes String input.
@ryanmelt ryanmelt added bug Something isn't working priority Priority issues driven by customers labels Jan 14, 2025
@jmthomas jmthomas self-assigned this Jan 17, 2025
@jmthomas jmthomas linked a pull request Jan 18, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmthomas jmthomas

Labels
bug Something isn't working priority Priority issues driven by customers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix write_conversion of default string to int and don't range check strings OpenC3/cosmos
2 participants
@jmthomas @ryanmelt