Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme clarification: Email settings in Admin panel are not the user's email settings. #20

Open
ThelsK opened this issue Oct 29, 2019 · 0 comments

Comments

@ThelsK
Copy link
Collaborator

ThelsK commented Oct 29, 2019

As of writing this issue, the Readme contains the following block of text:

  1. On the admin page, under the "Setup email verification" the password at the moment is the passowrd of the user's email id.
  • We need the email id and the passowrd of the user to send the verification mail but it would be ridiculous to ask the user for their password as well.
  • One way to get the password of the user is by adding a password textfield in the user signup and store the encrypted password(use bcrypt for encryption) in the configuration model in the backend with key as send_password.
  • To send the verification mail, you will need to bcrypt the user's password.
  • Start with removing the password field in the admin page under setup mail verification.

There is a misunderstanding here. The email and password entered there aren't the Admin user's email and password. They are the email and password of a single gmail account that is used to send the notification emails. This password cannot be encrypted, as Nodemailer requires this password to send email.

This is not the best way to send emails. Sending email through a service account would be a lot nicer. However, it seems not possible to get this to use without a G-Suite. Perhaps there are other alternatives to sending email verifications (connecting to an SMTP server or perhaps running your own SMTP server)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant