You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I don't think the GridSet object really needs to be called by users at all, as they are not manually defining gridsets. All the grid information is available to the users via the Field.grid attributes, and FieldSet.gridset attributes.
I also think that the GridSet itself can be majorly simplified (ie, add_grid() removed/majorly refactored, grids being an actual set, turning it into a dataclass) to the point that we could maybe even outright replace it with some utility functions/processors that pull grid information from the Fields. That's out of topic for this issue, just a hint to where I can see this going.
@erikvansebille any insight onto the history of the gridset class?
The text was updated successfully, but these errors were encountered:
Yes, good point. The GridSet is perhaps a bit over-engineered. The idea was to mimic the ParticleSet architecture/structure, but the GridSet is, as you say, much simpler; essentially just a list (set?) of Grids.
So yes, there could certainly be some cleaning here!
I don't think the
GridSet
object really needs to be called by users at all, as they are not manually defining gridsets. All the grid information is available to the users via theField.grid
attributes, andFieldSet.gridset
attributes.I also think that the
GridSet
itself can be majorly simplified (ie,add_grid()
removed/majorly refactored, grids being an actualset
, turning it into a dataclass) to the point that we could maybe even outright replace it with some utility functions/processors that pull grid information from the Fields. That's out of topic for this issue, just a hint to where I can see this going.@erikvansebille any insight onto the history of the gridset class?
The text was updated successfully, but these errors were encountered: