Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smarter time management in pset.execute() loop #1625

Open
erikvansebille opened this issue Jul 30, 2024 · 0 comments · May be fixed by #1627
Open

Smarter time management in pset.execute() loop #1625

erikvansebille opened this issue Jul 30, 2024 · 0 comments · May be fixed by #1627

Comments

@erikvansebille
Copy link
Member

The time management in the pset.execute() loop can be made a bit smarter. For example

  1. If the pset is empty, execution can in principle be stopped. Since we don't have a possibility to add particles at runtime (except if repeatdt is used), a run with an empty pset can be stooped. This would also avoid the warning (in particlefile that "ParticleSet is empty on writing as array at time")
  2. If there are no particle to be executed in the next loop, that loop can be fast-forwarded. For example, if the time counter is at t=3 (with a dt=1) and the next particle to start is at t=20, then the time can directly be moved to t=20. This saves I/O time for loading in unnecessary Field data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

Successfully merging a pull request may close this issue.

1 participant