Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration tests being skipped #1335

Closed
VeckoTheGecko opened this issue Mar 12, 2023 · 1 comment
Closed

Integration tests being skipped #1335

VeckoTheGecko opened this issue Mar 12, 2023 · 1 comment
Labels
bug

Comments

@VeckoTheGecko
Copy link
Contributor

VeckoTheGecko commented Mar 12, 2023 •
edited
Loading

In some of the workflow runs the integration tests are outright skipped, providing no error logs.

I've never seen this issue before in other codebases. Its cropped up in this repo for a couple months, most recently in #1328 (relevant comments 1 and 2) and in #1331 (screenshot of associated job run).

Its occuring on forks, as well as on internal repo branches.
@VeckoTheGecko VeckoTheGecko mentioned this issue Apr 2, 2023
Merged
6 tasks
@VeckoTheGecko
Copy link
Contributor Author

Whelp. Turns out I just completely missed the if: github.event.pull_request.draft == false line in the integration test workflow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@VeckoTheGecko