OXDEV-8216: Change constants to private; Add deactivation Exception t…

…est;
OXID-eSales · Aug 12, 2024 · 8299ccb · 8299ccb
1 parent 3004007
commit 8299ccb
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 3 deletions.
diff --git a/src/Module/Exception/ModuleActivationException.php b/src/Module/Exception/ModuleActivationException.php
@@ -13,7 +13,7 @@
 
 final class ModuleActivationException extends NotFound
 {
-    public const EXCEPTION_MESSAGE = "An error occurred while activating the module.";
+    private const EXCEPTION_MESSAGE = "An error occurred while activating the module.";
 
     public function __construct()
     {

diff --git a/src/Module/Exception/ModuleDeactivationException.php b/src/Module/Exception/ModuleDeactivationException.php
@@ -13,7 +13,7 @@
 
 final class ModuleDeactivationException extends NotFound
 {
-    public const EXCEPTION_MESSAGE = "An error occurred while deactivating the module.";
+    private const EXCEPTION_MESSAGE = "An error occurred while deactivating the module.";
 
     public function __construct()
     {

diff --git a/tests/Unit/Module/Exception/ModuleActivationExceptionTest.php b/tests/Unit/Module/Exception/ModuleActivationExceptionTest.php
@@ -10,18 +10,27 @@
 namespace OxidEsales\GraphQL\ConfigurationAccess\Tests\Unit\Module\Exception;
 
 use OxidEsales\GraphQL\ConfigurationAccess\Module\Exception\ModuleActivationException;
+use OxidEsales\GraphQL\ConfigurationAccess\Module\Exception\ModuleDeactivationException;
 use PHPUnit\Framework\TestCase;
 
 /**
  * @covers \OxidEsales\GraphQL\ConfigurationAccess\Module\Exception\ModuleActivationException
  */
 final class ModuleActivationExceptionTest extends TestCase
 {
-    public function testException(): void
+    public function testActivationException(): void
     {
         $exception = new ModuleActivationException();
 
         $this->assertInstanceOf(ModuleActivationException::class, $exception);
         $this->assertSame('An error occurred while activating the module.', $exception->getMessage());
     }
+
+    public function testDeactivationException(): void
+    {
+        $exception = new ModuleDeactivationException();
+
+        $this->assertInstanceOf(ModuleDeactivationException::class, $exception);
+        $this->assertSame('An error occurred while deactivating the module.', $exception->getMessage());
+    }
 }