Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logging - first pass #50

Open
1 task
mikeAdamss opened this issue Mar 6, 2024 · 1 comment
Open
1 task

logging - first pass #50

mikeAdamss opened this issue Mar 6, 2024 · 1 comment

Comments

@mikeAdamss
Copy link
Contributor

DEPENDS ON: ONSdigital/dp-python-tools#25

What is this

Add basic logging statements using the logger from dp-python-tools.

This will look a bit odd as its structure jsonlines but that;'s ok - this is the format requried for kibana and strcutured logging (which we will need down the line).

What to do

Sprinkle logging statments in.

Always start each function with some variation of an "I have started" function including the relvant variables.

Beyond that at any point we do a try catch either (a) log we succeeded with any relevant variables or (b) if we fail the try catch - log the problem before we send a notification.

The trick here is to think of it from the perspective of yourself if you were trying to debug unexpected behaviour in the pipeline.

Acceptance Criteria

  • Logging statments added.
@martynspooner
Copy link

3pts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants