Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code quality tools to cover test code #112

Open
3 tasks
mikeAdamss opened this issue Apr 17, 2024 · 0 comments
Open
3 tasks

code quality tools to cover test code #112

mikeAdamss opened this issue Apr 17, 2024 · 0 comments

Comments

@mikeAdamss
Copy link
Contributor

What is this

We're currently running black, isort and ruff on the application code not on the test code.

This is resulting in a noticable difference in quality.

We need to adapt the github actions to run against the ./tests/ directory as well as the application code. Where we have a featurees directory as well please run the tools against those too.

What do do

Update makefile to run against additional locations.
Update github actions with damr logic.
Run make fmt against new locations and fix any issues flagged by make lint

Acceptance Criteria

  • Logic updated in make
  • Logic updated in actions
  • Linting issues addressed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant