Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Grey hero variant - statistics logo is larger than the figma design, and unlinked #3485

Open
helenb opened this issue Feb 3, 2025 · 0 comments
Labels
Bug Something isn't working Community backlog An issue raised on the community backlog High priority

Comments

@helenb
Copy link

helenb commented Feb 3, 2025

Describe the bug

The statistics logo is too large, and also creates too much space between the title and the summary below.
We need an option to add a url when including the statistics logo.

Using the grey hero component:

Image

Expected behaviour / outcome

This is how it should look:

Image

The logo should be 90px wide.

It should link to https://uksa.statisticsauthority.gov.uk/about-the-authority/uk-statistical-system/types-of-official-statistics/

Note that in this example the title and summary are wrapped in the same div, which both sit to the left of the logo, so the logo does not affect the spacing between the title and summary. Here it is with the flex layout highlighted:

Image

List the steps necessary to reproduce the bug

Create a grey onsHero variant, and ensure that the option for officialStatisticsBadge is set to be true. Observer the image size, layout issues, and lack of link.

Additional context

No response

What version of the ONS Design System are you using?

72.2.0

What device(s) are you using?

Desktop

What operating system(s) are you using?

macOS

What browser(s) are you using?

Chrome

@helenb helenb added Bug Something isn't working Community backlog An issue raised on the community backlog High priority labels Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Community backlog An issue raised on the community backlog High priority
Projects
None yet
Development

No branches or pull requests

1 participant