Merge pull request kosmos-io#757 from OrangeBao/main

fix: create api-server-external-service
ONE7live · Nov 1, 2024 · 37cb260 · 37cb260
2 parents 21229cb + 6b0f55b
commit 37cb260
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/cmd/kubenest/node-agent/app/serve/serve.go b/cmd/kubenest/node-agent/app/serve/serve.go
@@ -57,7 +57,7 @@ func init() {
 func serveCmdRun(_ *cobra.Command, _ []string) error {
 	user := viper.GetString("WEB_USER")
 	password := viper.GetString("WEB_PASS")
-        port := viper.GetString("WEB_PORT")
+	port := viper.GetString("WEB_PORT")
 	if len(user) == 0 || len(password) == 0 {
 		log.Errorf("-user and -password are required %s %s", user, password)
 		return errors.New("-user and -password are required")

diff --git a/pkg/kubenest/controlplane/endpoint.go b/pkg/kubenest/controlplane/endpoint.go
@@ -105,12 +105,14 @@ func CreateOrUpdateAPIServerExternalService(kubeClient kubernetes.Interface) err
 	}
 	_, err = kubeClient.CoreV1().Services(constants.DefaultNs).Get(context.TODO(), constants.APIServerExternalService, metav1.GetOptions{})
 	if err != nil {
-		if !apierrors.IsNotFound(err) {
+		if apierrors.IsNotFound(err) {
 			// Try to create the service
 			_, err = kubeClient.CoreV1().Services(constants.DefaultNs).Create(context.TODO(), &svc, metav1.CreateOptions{})
 			if err != nil {
 				return fmt.Errorf("error when creating api-server-external-service: %w", err)
 			}
+		} else {
+			return fmt.Errorf("error when get api-server-external-service: %w", err)
 		}
 	}
 	klog.V(4).Info("successfully created api-server-external-service service")