Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AssertionError: There is not one key signature exactly for each staff #1

Open
eoinroe opened this issue Jan 3, 2025 · 2 comments
Open

Comments

@eoinroe
Copy link

eoinroe commented Jan 3, 2025

I have exported a musicxml file from Dorico to try out Smashcima. However, I am getting an assertion error regarding the use of key signatures:

assert set(self.clefs.keys()) == set(range(1, self.staff_count+1)), \
     31             "There is not one clef exactly for each staff"
---> 32         assert set(self.keys.keys()) == set(range(1, self.staff_count+1)), \
     33             "There is not one key signature exactly for each staff"
     34 

AssertionError: There is not one key signature exactly for each staff

This is strange since the solo piano excerpt I am using appears to have the correct number of key signatures:

Screenshot 2025-01-03 at 18 53 03

This seems to be an issue with grand stave instruments since this was not a problem with a solo violin excerpt I tried. However, the key signature of the violin excerpt was not included in the final render.

@Jirka-Mayer
Copy link
Collaborator

Smashcima was tested on MuseScore 3.6.2 musicxml outputs, maybe try loading the Dorico musicxml file in MuseScore and then exporting it again. It should fix it.

Also, could you send me the Dorico's musicxml file here? I'll look into the XML to see what the problem might be and possibly fix it. Thanks!

@eoinroe
Copy link
Author

eoinroe commented Jan 9, 2025

Thank you, exporting the musicxml file from MuseScore fixes the problem. However, the ties, dynamics and key signatures do not show up in the generated handwritten score. Is there a reason for this?

Screenshot 2025-01-09 at 13 39 08

Here is a link for the Dorico musical files - https://we.tl/t-utBasDfgXB

(It seems they can not be attached as part of this chat)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants