Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Probe voxel index and instance scroll index do not match #4573

Open
pwespi opened this issue Dec 4, 2024 · 1 comment
Open

[Bug] Probe voxel index and instance scroll index do not match #4573

pwespi opened this issue Dec 4, 2024 · 1 comment
Labels
Awaiting Reproduction Can we reproduce the reported bug?

Comments

@pwespi
Copy link
Contributor

pwespi commented Dec 4, 2024

Describe the Bug

When using the probe tool, the z index does not match the instance scroll index. The probe tool index is zero-based, while the instance scroll index is one-based. This can be confusing when talking about voxel coordinates.

Screenshot 2024-12-04 at 10 01 50

Steps to Reproduce

  1. Open any study in current OHIF
  2. Use the probe tool
  3. Compare the voxel index of the probe tool with the instance scroll index

The current behavior

Probe voxel index and instance scroll index do not match

The expected behavior

Probe voxel index and instance scroll index should match

OS

macOS

Node version

v20.14.0

Browser

Firefox

@pwespi pwespi added the Awaiting Reproduction Can we reproduce the reported bug? label Dec 4, 2024
@sedghi
Copy link
Member

sedghi commented Dec 5, 2024

Instance number is correct (I:73), it can be anything e..,g 111455, and it doesn't need to change across instances

then there is a slice number (73/763), the 763 is number of slices which starts at 1 and 73/763 is correct too

Now the question is what do we show for the probe index (it is IJK), which is again correct since they start at 0

So it is about representing couple of things that are different concepts. What other viewers you have in house that you can try and let us know?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Reproduction Can we reproduce the reported bug?
Projects
None yet
Development

No branches or pull requests

2 participants