Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Location table is orphaned #82

Open
katy-sadowski opened this issue Oct 10, 2024 · 1 comment · May be fixed by #83
Open

Location table is orphaned #82

katy-sadowski opened this issue Oct 10, 2024 · 1 comment · May be fixed by #83
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@katy-sadowski
Copy link
Collaborator

It doesn't connect to any other tables right now, but it should actually have FKs in PERSON and PROVIDER. We should figure out how to link back each person/provider to their location in this table. As part of this, locations should also be de-duped.

@lawrenceadams
Copy link
Collaborator

lawrenceadams commented Oct 11, 2024

Scoping

Effects the care_site and person table: at present all locations data comes from seeds/synthea/patients.csv and trickles into location from stg_synthea__patients. An interesting oversight from the original SyntheaOMOP project as this violates the CDM and doesn't even bother to dedup. Nice catch @katy-sadowski !

Given Synthea doesn't normalise locations at all I'd imagine we will have to hoover up all locations synthea generates for patients and care sites and then use the various aspects of the address as a natural key to join onto

@lawrenceadams lawrenceadams added bug Something isn't working enhancement New feature or request labels Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants