Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add time measurements to plpLog #418

Open
egillax opened this issue Oct 17, 2023 · 0 comments
Open

Add time measurements to plpLog #418

egillax opened this issue Oct 17, 2023 · 0 comments

Comments

@egillax
Copy link
Collaborator

egillax commented Oct 17, 2023

I think it would be good to add time measurement to each step in runPlp and the total time. I already did so in the arrow branch when I was comparing the old and new performance. See example here in createStudyPopulation .

This requires putting the following as he first thing the function executes:

  startTime <- Sys.time()

And at the end of the function as the last thing it executes:

delta <- Sys.time() - startTime
ParallelLogger::logInfo("Creating study population took ", signif(delta, 3), " ", attr(delta, "units"))

Replacing the text in logInfo with what is appropriate for the function.

Functions which I believe would be useful to add timings to:

  • createStudyPopulation
  • splitData
  • sampleData
  • featureEngineer
  • preprocessData (there might be one already in tidyCovariates, in that case it can be skipped here)
  • fitPlp
  • predictPlp
  • evaluatePlp
  • covariateSummary
  • runPlp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant