Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow interval = NULL, unitInterval = NULL in summariseConceptCounts when no stratification per unit interval of time wants to be performed #195

Open
martaalcalde opened this issue Oct 17, 2024 · 3 comments · May be fixed by #209
Assignees

Comments

@martaalcalde
Copy link
Collaborator

What do you think, @catalamarti ?

@catalamarti
Copy link
Collaborator

Mmmm The more I think would be nice to align with IncidencePrevalence:
https://darwin-eu.github.io/IncidencePrevalence/reference/estimateIncidence.html

Then my suggestion would be two arguments:

  • interval (overall/years/quarters/months/weeks/days) we can for the moment only allow
  • intervalValue: by default 1, but can allow to change it

What do you think @martaalcalde
This would allow overall option (happy to include an option that if NULL -> overall)
Allow the value thingy
Align with IncidencePrevalence

@martaalcalde
Copy link
Collaborator Author

Change start of the database to the nearest multiple of five year

@martaalcalde
Copy link
Collaborator Author

Change it in:

  • summariseRecordCount
  • summariseConceptCount
  • summariseInObservation

@martaalcalde martaalcalde self-assigned this Oct 17, 2024
@martaalcalde martaalcalde changed the title Allow unit = NULL, unitInterval = NULL in summariseConceptCounts when no stratification per unit interval of time wants to be performed Allow interval = NULL, unitInterval = NULL in summariseConceptCounts when no stratification per unit interval of time wants to be performed Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants