From 925277b1464ffab1b9dd60428c1d69e50879e7a9 Mon Sep 17 00:00:00 2001
From: egillax <egillax@gmail.com>
Date: Thu, 1 Aug 2024 20:15:48 +0200
Subject: [PATCH] revise check command and install qpdf

---
 .Rbuildignore                         |  3 +++
 .github/workflows/release_docker.yaml | 16 ++++++++--------
 Dockerfile                            |  1 +
 3 files changed, 12 insertions(+), 8 deletions(-)

diff --git a/.Rbuildignore b/.Rbuildignore
index 9ba1d8b..8e874e6 100644
--- a/.Rbuildignore
+++ b/.Rbuildignore
@@ -13,3 +13,6 @@
 ^.*\.pt$
 ^doc$
 ^Meta$
+^Dockerfile$
+^\.devcontainer
+^\.vscode
diff --git a/.github/workflows/release_docker.yaml b/.github/workflows/release_docker.yaml
index 2d13f20..a965ece 100644
--- a/.github/workflows/release_docker.yaml
+++ b/.github/workflows/release_docker.yaml
@@ -124,14 +124,14 @@ jobs:
       - name: Run R CMD check
         run: |
           digest=$(ls /tmp/digests)
-          # Build the package
-          docker run --rm -v $(pwd):/workspace -w /workspace ${{ env.DOCKER_IMAGE }}@sha256:$digest R CMD build .
-
-          # Extract the name of the generated tar.gz file
-          package_file=$(ls *.tar.gz)
-
-          # Run package checks on the tar.gz file
-          docker run --rm -v $(pwd):/workspace -w /workspace ${{ env.DOCKER_IMAGE }}@sha256:$digest R CMD check --no-manual --as-cran $package_file
+          # Run package checks
+          docker run --rm \ 
+          -e _R_CHECK_FORCE_SUGGESTS_=false \
+          -e _R_CHECK_CRAN_INCOMING_=false  \
+          -v $(pwd):/workspace -w /workspace \
+          ${{ env.DOCKER_IMAGE }}@sha256:$digest Rscript -e \ 
+          "install.packages('rcmdcheck');rcmdcheck::rcmdcheck('.', args=c('--no-manual', '--as-cran'), \ 
+          build_args = '--no-manual', error_on = 'warning')"
 
   merge:
     runs-on: ubuntu-latest
diff --git a/Dockerfile b/Dockerfile
index 84b9967..eb58d43 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -73,6 +73,7 @@ COPY --from=build /usr/local/lib/R/library /usr/local/lib/R/library
 ENV RETICULATE_PYTHON=/usr/bin/python3
 # runtime dependanceis
 RUN apt-get -y update && apt-get install -y \
+      qpdf \
       default-jre \
       default-jdk \
       libssl3 \