Allow read-only custom feature browsing #2975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Nov 6, 2024
anthonysena
commented
Nov 6, 2024
| <div data-bind="if: $data.criteriaType === 'WindowedCriteria'"> | ||
| <windowed-criteria params="{ expression: { ConceptSets: $component.data().conceptSets }, criteria: $data.expression, disableObservationPeriod: true, defaultObservationPeriod: true }"></windowed-criteria> | ||
| </div> | ||
| <div data-bind="css: $component.canEdit() ? '' : 'feature-analysis-view-edit__content--disabled'"> |
There was a problem hiding this comment.
This CSS class feature-analysis-view-edit__content--disabled is defined by the parent component and I was not sure how to best use it so for now it is hardcoded.
There was a problem hiding this comment.
@alex-odysseus do you or anyone from your team provide a suggestion to handle this CSS approach?
There was a problem hiding this comment.
Just to follow up on this item: I've attempted to edit the child .less sheets to include the disabled BEM modifier without much luck. I'd propose just hard-coding this now.
chrisknoll
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies the custom feature editor to allow for browsing concept sets when in read-only mode per #2532. These changes also enable the copy SQL to clipboard per #2812.