Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CustomUri function related issues #2712

Open
xuzhg opened this issue Aug 1, 2023 · 0 comments · May be fixed by #2715
Open

CustomUri function related issues #2712

xuzhg opened this issue Aug 1, 2023 · 0 comments · May be fixed by #2715
Assignees

Comments

@xuzhg
Copy link
Member

xuzhg commented Aug 1, 2023

1

CustomUriFunctions uses a global static dictionary at here, it's global scope, not Edm model scoped.

It's not a good design, we should fix it. see #378 (comment)

In ODL 7.x, we can introduce an new option for customers to use 'annotation' to config the customUriFuncions, but keep the static dictionary for back compatibility.
In ODL 8, remove the static dictionary

2

In OData lib parser, it starts to parse the parameter value, then uses the function name and parsed value to match the defined functions. Since there's no parameter type information at the beginning when parsing the parameter value, ODL parses the 'collection literal' as a single string value. As a result, it can't match the parameter type if we define the second parameter type as a collection of string. See details at OData/AspNetCoreOData#1003

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants