Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating a module base_property to be the base of pms/realestate/other repos that share property concept #319

Open
cvinh opened this issue Jan 20, 2025 · 3 comments
Labels
enhancement New feature or request

Comments

@cvinh
Copy link

cvinh commented Jan 20, 2025

PMS, REMS and other vertical modules need the concept of property.

In that goal we choose to make a new base_property with common fields that could be shared with other vertical modules (starting with pms_base and real_estate)

BTW , why not res_property ? to be aligned with odoo's res_*...

@cvinh cvinh added the enhancement New feature or request label Jan 20, 2025
@pedrobaeza
Copy link
Member

Usually res is not used in module names. We use base_something or directly the name. The module may be called simply property if you want.

@cvinh
Copy link
Author

cvinh commented Jan 20, 2025

Usually res is not used in module names. We use base_something or directly the name. The module may be called simply property if you want.

base_property is fine for me because we say in the name that this module is a base for something else...
About the model, can it be res.property then ?

@DarioLodeiros
Copy link
Member

There is the module multi_pms_properties, which is designed to add certain common features to property management and could serve as a good foundation for a common properties module across repositories. There is no problem in renaming it to base_property, although since the concept of "property" is widely used in the code for generic purposes, we thought it was more appropriate to introduce the pms prefix to avoid confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants