Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pending TODO: Using uppercase extension for files in hooks.yaml? #60

Open
antonag32 opened this issue Nov 11, 2022 · 0 comments
Open

Pending TODO: Using uppercase extension for files in hooks.yaml? #60

antonag32 opened this issue Nov 11, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@antonag32
Copy link
Contributor

I don't think we should let TODOs exist for too long (I personally believe they should not be committed to main), and while browsing the code I found this existing TODO:

- id: oca-checks-odoo-module
  name: Checks for Odoo modules
  description: Multiple checks for Odoo modules
  entry: oca-checks-odoo-module
  args: []
  language: python
  types_or: ["csv", "python", "xml"]
  # TODO: Check if should consider uppercase extension
  files: \.(csv|xml)$|/\_\_(manifest|openerp)\_\_.py$

If I understand correctly, currently mymodule.xml will be passed on to the hook, but mymodule.XML won't. I think this is fine but we might as well settle the debate to end this TODO.

@antonag32 antonag32 added the enhancement New feature or request label Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant