Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No remote sources in manifest assets #124

Open
antonag32 opened this issue Jan 31, 2025 · 0 comments
Open

No remote sources in manifest assets #124

antonag32 opened this issue Jan 31, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@antonag32
Copy link
Contributor

Is your feature request related to a problem?
Using public CDNs is considered a bad practice. Therefore we should verify that no remote assets are referenced in modules' manifest files. For example, the following snippet in a __manifest__.py is not a good idea:

"assets": {
        "web.assets_frontend": ["https://some.random.cdn/myfile.js"]
}

Important, this only applies to content inside the assets key, as module descriptions may reference websites and that is fine.

Describe the solution you'd like
A new lint that checks for remote URLs inside manifest assets.

@antonag32 antonag32 added the enhancement New feature or request label Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant