-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create GALLONT.md #2541
Create GALLONT.md #2541
Conversation
following instructions here: OBOFoundry#2522 (comment)
cc @adeans please check that my changes are still correct.
ontology/GALLONT.md
Outdated
- id: ncbitaxon | ||
description: Ontology of plant gall phenotypes | ||
domain: phenotype | ||
homepage: https://github.com/adeans/gallont/tree/main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strange homepage link. Did you consider using the ODK documentation feature to generate a proper documentation page like https://pato-ontology.github.io/pato/?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(not a requirement)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strange homepage link. Did you consider using the ODK documentation feature to generate a proper documentation page like https://pato-ontology.github.io/pato/?
Oh yah. That would be preferable. I must've missed it in the ODK package. Is there documentation somewhere that would walk me through it? Somewhere in here? https://ontology-development-kit.readthedocs.io/en/latest/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You add this to the ODK config:
https://github.com/obophenotype/human-phenotype-ontology/blob/53c4e0dcf3337e223c9afcd29dfb18e7ed372e7a/src/ontology/hp-odk.yaml#L182
then run update_repo twice
then set up your github pages like this:
Sorry for not having better docs on this :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I think I am close. Where do I "run update_repo twice"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @matentzn. I made progress (I think), but I get two QC errors now:
- https://github.com/adeans/gallont/actions/runs/8266804229/job/22615690174 ("Error: Process completed with exit code 2.")
- https://github.com/adeans/gallont/actions/runs/8266804231/job/22615690162 ("The "table-reader" plugin is not installed")
Are these easy?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The second seems to be a bug.
Lets start with the first https://github.com/adeans/gallont/actions/runs/8266804229/job/22615690174
This is a QC check that reflects the OBO foundries decision to fade out the dc elements namespace in favour of dc terms. So in your ontology, you need to replace all occurrences of the old dc elements namespace with dcterms.
The second can be circumvented by manually deleting this row:
https://github.com/adeans/gallont/blob/37daf2a543720392d16afb28b9031d0af6d8a796/mkdocs.yaml#L8
I would apprciate if you could make a bug report in the ODK repo though, as this needs to be fixed urgently.. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adeans please also change the rest of my formatting changes!
added better(?) description
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some other folks are a bit stricter on metadata than me, so we should give them until thursday to provide a review
added .obo and .json to products
removed .json product
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hopefully I did this correctly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its done now. I am not sure if @deepakunni3 is at the moment around, so I will merge this to have it ready for the newsletter on Monday.
@matentzn Yes, I would not have been able to get this merged until today. |
following instructions here: #2522 (comment)