Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the download ontology process #132

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Conversation

anitacaron
Copy link
Collaborator

This PR updates how to download an ontology. It gets a more robust system.

Previously it just called a function from urllib.request to download the ontology and save it in a file.

Now I created a function to stream the download and also retry download 3x in case of error, especially ChunkedEncodingError which was the original issue.

Fixes #130

@anitacaron anitacaron self-assigned this Aug 21, 2024
@anitacaron anitacaron requested a review from matentzn August 21, 2024 15:28
@matentzn matentzn requested a review from jsstevenson August 21, 2024 21:45
Copy link
Contributor

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, but I assigned @jsstevenson for a more pythonic review, as my pythonic is rusty

util/dashboard_config.py Show resolved Hide resolved
@anitacaron anitacaron merged commit ea99dd2 into master Aug 29, 2024
1 check passed
@anitacaron anitacaron deleted the anitacaron/issue130 branch August 29, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when downloading NCBITaxon
3 participants