Relax semantic versioning pattern #105
Conversation
Co-authored-by: Jim Balhoff <[email protected]>
There was a problem hiding this comment.
Why did you change the patterns for dated version iris?
Let's try to get for any change we do at least one other obo tech wg person to review.
I guess you are trying to run this now, but I don't think it should be necessary to drop the strict obo version iri refer check (just semver)
|
I saw Jim reviewed it 😷 sorry. But the question remains.. |
Ah sorry, I was only focused on the numbered version part. I did not check the dated version pattern! |
There's already a date pattern in the next line in the file... It wasn't checking for the purl anymore, that's why I changed it. |
| PATTERN = re.compile(pat) | ||
| #: Official regex for semantic versions from https://semver.org/#is-there-a-suggested-regular-expression-regex-to-check-a-semver-string | ||
| SEMVER_PATTERN = re.compile(r"^(0|[1-9]\d*)\.(0|[1-9]\d*)(\.(0|[1-9]\d*))?(?:-((?:0|[1-9]\d*|\d*[a-zA-Z-][0-9a-zA-Z-]*)(?:\.(?:0|[1-9]\d*|\d*[a-zA-Z-][0-9a-zA-Z-]*))*))?(?:\+([0-9a-zA-Z-]+(?:\.[0-9a-zA-Z-]+)*))?$") | ||
| # Simplify semantic versions to accept only numbers with or without point, .eg 1.1 or 11 | ||
| SEMVER_PATTERN = re.compile(r"^(0|[1-9]\d*)(\.)?(0|[1-9]\d*)?((\.)?(0|[1-9]\d*))?$") |
There was a problem hiding this comment.
You are missing quite a bit here: https://semver.org/
Semantic Versioning is a standard which allows versions like these:
- 1.0.0-alpha
- 1.0.0-alpha+001
- 1.0.0+20130313144700
- 1.0.0-beta+exp.sha.5114f85
I would suggest we use the official semver regex: https://semver.org/#is-there-a-suggested-regular-expression-regex-to-check-a-semver-string
Fixes #104