Skip to content

Commit

Permalink
download ontology using stream option and save in chunks for efficien…
Browse files Browse the repository at this point in the history
…cy on large ontology
  • Loading branch information
anitacaron committed Aug 21, 2024
1 parent e39cde9 commit 2fde802
Show file tree
Hide file tree
Showing 2 changed files with 41 additions and 16 deletions.
26 changes: 13 additions & 13 deletions util/dashboard_config.py
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
#!/usr/bin/env python3

import os
import yaml
import click
import logging
import urllib.request
import json
import logging
import os


from lib import DashboardConfig, runcmd, sha256sum, save_yaml, \
load_yaml, robot_prepare_ontology, get_hours_since, get_base_prefixes, \
compute_percentage_reused_entities, round_float, create_dashboard_score_badge, \
create_dashboard_qc_badge
import click
import requests
import yaml
from lib import (DashboardConfig, compute_percentage_reused_entities,
create_dashboard_qc_badge, create_dashboard_score_badge,
download_file, get_base_prefixes, get_hours_since, load_yaml,
robot_prepare_ontology, round_float, runcmd, save_yaml,
sha256sum)

logging.basicConfig(level=logging.INFO)

Expand Down Expand Up @@ -190,11 +190,11 @@ def prepare_ontologies(ontologies, ontology_dir, dashboard_dir, make_parameters,
continue

if download:
logging.info(f"Downloading {o}...")
logging.info("Downloading %s...", o)
try:
urllib.request.urlretrieve(ourl, ont_path)
download_file(ourl, ont_path)
except Exception:
logging.exception(f'Failed to download {o} from {ourl}')
logging.exception("Failed to download %s from %s", o, ourl)
ont_results['failure'] = 'failed_download'
save_yaml(ont_results, ont_results_path)
create_dashboard_qc_badge("red", "Failed to download", ont_dashboard_dir)
Expand Down
31 changes: 28 additions & 3 deletions util/lib.py
Original file line number Diff line number Diff line change
@@ -1,15 +1,17 @@
#!/usr/bin/env python3

import yaml
import hashlib
import json
import logging
import subprocess
import threading
import urllib.request
import hashlib
from datetime import datetime
from subprocess import check_call

import requests
from datetime import datetime
import yaml
from requests.exceptions import ChunkedEncodingError

obo_purl = "http://purl.obolibrary.org/obo/"

Expand Down Expand Up @@ -574,3 +576,26 @@ def url_exists(url: str) -> bool:
# as the URL not existing
logging.error(e, exc_info=True)
return False


def download_file(url, dest_path, retries=3):
"""
Download the ontology from the URL to a local path. Retries on ChunkedEncodingError.
"""
attempt = 0
while attempt < retries:
try:
response = requests.get(url, stream=True, timeout=1000000)
response.raise_for_status()

with open(dest_path, 'wb') as f:
for chunk in response.iter_content(chunk_size=32768):
if chunk: # filter out keep-alive new chunks
f.write(chunk)
logging.info("Downloaded %s to %s", url, dest_path)
return # Exit the function if download is successful
except ChunkedEncodingError as e:
attempt += 1
logging.warning("ChunkedEncodingError encountered: %s. Retrying %s/%s...", e, attempt, retries)
except Exception as e:
logging.exception("Failed to download %s: %s", url, e)

0 comments on commit 2fde802

Please sign in to comment.