Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize query operations #871

Open
OmarTawfik opened this issue Mar 2, 2024 · 0 comments
Open

optimize query operations #871

OmarTawfik opened this issue Mar 2, 2024 · 0 comments
Assignees

Comments

@OmarTawfik
Copy link
Contributor

OmarTawfik commented Mar 2, 2024

Examples:

  • go_to_nth_child might be quicker to start from the end (like go_to_last_child) - actually a Cursor optimisation.
  • the combinators are strictly FIFO during the search, so can be allocated and deallocated using a single block of memory, avoiding all allocation.
  • binding names can be shared, rather than allocated.
  • before searching over a tree, a hash map can be built keyed by the FIRST SET of the kinds of each query, avoiding the cost of iterating over the queries for each node.

Please check the TODO(#871) comments added in #873.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

2 participants