Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

customized TextIndex tracking #817

Open
OmarTawfik opened this issue Feb 15, 2024 · 1 comment
Open

customized TextIndex tracking #817

OmarTawfik opened this issue Feb 15, 2024 · 1 comment

Comments

@OmarTawfik
Copy link
Contributor

OmarTawfik commented Feb 15, 2024

This type is already tracking three values (utf8, utf16, char), and two more with #683 (line, column). is it worth it to only allow a subset through Cargo features, thus preserving memory usage?

Once we have #808, we should probably measure its impact and decide if we should support this:

  • For Rust users, they can enable/disable the values they care about.
  • For TS users, can we choose a reasonable default. For example, is utf8 ever used/needed in NodeJS?

If perf shows that there is no measurable difference between 1 and 5 values, then it is a good reason to skip this.

@OmarTawfik OmarTawfik converted this from a draft issue Feb 15, 2024
@Xanewok
Copy link
Contributor

Xanewok commented Mar 4, 2024

We need numbers, but I don't think this is worth pursuing for Rust as the cost will probably be negligible; maybe more so for TS users.

@Xanewok Xanewok removed their assignment May 17, 2024
@OmarTawfik OmarTawfik moved this to Todo in Slang - Backlog Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

2 participants