You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When having overloaded functions, it seems that the first function that matches the name comes first but parameters may have not been checked. Take for instance
/** * @dev Revert with a standard message if `_msgSender()` is missing `role`. * Overriding this function changes the behavior of the {onlyRole} modifier. * * Format of the revert message is described in {_checkRole}. * * _Available since v4.6._ */function _checkRole(bytes32role) internalviewvirtual {
_checkRole(role, _msgSender());
}
/** * @dev Revert with a standard message if `account` is missing `role`. * * The format of the revert reason is given by the following regular expression: * * /^AccessControl: account (0x[0-9a-f]{40}) is missing role (0x[0-9a-f]{64})$/ */function _checkRole(bytes32role, addressaccount) internalviewvirtual {
if (!hasRole(role, account)) {
revert(
string(
abi.encodePacked(
"AccessControl: account ",
Strings.toHexString(account),
" is missing role ",
Strings.toHexString(uint256(role), 32)
)
)
);
}
}
When going to definition on the
function _checkRole(bytes32role) internalviewvirtual {
_checkRole(role, _msgSender());
}
it leads to the same function (function _checkRole(bytes32 role)) while the parameters does not match.
The text was updated successfully, but these errors were encountered:
This has been a long standing issue. We hope to leverage the Slang binding API to provide us with accurate definition/usage information in these scenarios.
However, we likely can do better in this case without blocking on pulling in Slang's binding API for all document analysis.
When having overloaded functions, it seems that the first function that matches the name comes first but parameters may have not been checked. Take for instance
When going to definition on the
it leads to the same function (
function _checkRole(bytes32 role)
) while the parameters does not match.The text was updated successfully, but these errors were encountered: