[Feature] Go To Definition does not work or is not fully resolved

[DrakeEvans]

Feature: Go To Definition should support function definitions as well as fully resolve Definitions

Current Situation: Function definitions not supported, For supported symbols Go To Definition only goes to the nearest declaration not to the implementation

Current.mp4

Proposed: Function definitions supported, Go To Definition fully resolves to implementation not nearest declaration

OptimalOutcome.mp4

[DrakeEvans]

The OptimalOutcome.mp4 is generated from using the Tools For Solidity extension

[kanej]

Hey @DrakeEvans, thanks for the reproduction videos they are always valued.
Can you point me to to the repo you where using if its open source?

[DrakeEvans]

@kanej Yes you can see it at https://github.com/agora-finance/agora-dollar-evm-tests/blob/master/src/test/erc20-privilaged/TestMinting.t.sol

You will need to run forge install and npm i to make it work

[DrakeEvans]

Will need to run npm i inside of one submodule as well cd lib/agora-dollar-evm/ && npm i

[moray5554]

so there is no way to fix this thing? I experiencing the same with almost every project

[DrakeEvans]

so there is no way to fix this thing? I experiencing the same with almost every project

Im not a contributor but this may be fixed as they move to a different syntax tree parser. You can check out the slaang project

[kanej]

so there is no way to fix this thing? I experiencing the same with almost every project

Im not a contributor but this may be fixed as they move to a different syntax tree parser. You can check out the slaang project

That is correct. We are rolling out Slang internally within the extension (it is currently used to support the outline view).

The Slang project is working on Solidity lang binding information to enable go to definition type use cases. Once we have integrated Slang's binding info and its more robust project analysis, there should be significant improvements in our navigation support.