Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config field to enable legacy gas fields to network config #842

Open
zoeyTM opened this issue Nov 27, 2024 · 0 comments
Open

Add config field to enable legacy gas fields to network config #842

zoeyTM opened this issue Nov 27, 2024 · 0 comments
Labels
status:ready This issue is ready to be worked on

Comments

@zoeyTM
Copy link
Contributor

zoeyTM commented Nov 27, 2024

Rather than support and maintain a potentially indefinite list of networks who require legacy gas fields, we want to add a new field to HardhatNetworkUserConfig.ignition called useLegacyGasFields that will enable this functionality on a per-network basis.

Something like this:

export interface HardhatNetworkUserConfig {
    ignition?: {
      maxFeePerGasLimit?: bigint;
      maxPriorityFeePerGas?: bigint;
      gasPrice?: bigint;
      disableFeeBumping?: boolean;
      useLegacyGasFields?: boolean;
    };
  }

  export interface HardhatNetworkConfig {
    ignition: {
      maxFeePerGasLimit?: bigint;
      maxPriorityFeePerGas?: bigint;
      gasPrice?: bigint;
      disableFeeBumping?: boolean;
      useLegacyGasFields?: boolean;
    };
  }

  export interface HttpNetworkUserConfig {
    ignition?: {
      maxFeePerGasLimit?: bigint;
      maxPriorityFeePerGas?: bigint;
      gasPrice?: bigint;
      disableFeeBumping?: boolean;
      useLegacyGasFields?: boolean;
    };
  }

  export interface HttpNetworkConfig {
    ignition: {
      maxFeePerGasLimit?: bigint;
      maxPriorityFeePerGas?: bigint;
      gasPrice?: bigint;
      disableFeeBumping?: boolean;
      useLegacyGasFields?: boolean;
    };
  }

That would enable the logic here:

https://github.com/NomicFoundation/hardhat-ignition/blob/development/packages/core/src/internal/execution/jsonrpc-client.ts#L649-L652

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:ready This issue is ready to be worked on
Projects
Status: Todo
Development

No branches or pull requests

1 participant