Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect and report contract size limit errors #824

Open
alcuadrado opened this issue Oct 17, 2024 · 1 comment
Open

Detect and report contract size limit errors #824

alcuadrado opened this issue Oct 17, 2024 · 1 comment
Assignees
@zoeyTM
Labels
status:ready This issue is ready to be worked on type:improvement An enhancement to an existing feature

Comments

@alcuadrado
Copy link
Member

alcuadrado commented Oct 17, 2024 •
edited
Loading

Describe the feature

Ignition module executions can fail with "Reverted without error reason" when there's a contract size limit error. While this is technically the correct error that the EVM returns in these cases, we can detect and report/prevent this issue.

Related EIPs:

Search terms

error-handling, execution
@alcuadrado
Copy link
Member Author

Note that when connected to Hardhat Network we would be under a special case, as it already reports EIP-170 violations, just like it reports custom errors.

@kanej kanej added status:ready This issue is ready to be worked on type:improvement An enhancement to an existing feature and removed status:triaging labels Oct 21, 2024
@kanej kanej moved this to Todo in Hardhat Ignition Oct 21, 2024
@zoeyTM zoeyTM self-assigned this Oct 22, 2024
@zoeyTM zoeyTM moved this from Todo to In Progress in Hardhat Ignition Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zoeyTM zoeyTM

Labels
status:ready This issue is ready to be worked on type:improvement An enhancement to an existing feature
Projects
Hardhat Ignition
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kanej @alcuadrado @zoeyTM