Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bail_on_(call|transaction)_failure from EDR #743

Open
agostbiro opened this issue Dec 10, 2024 · 2 comments
Open

Remove bail_on_(call|transaction)_failure from EDR #743

agostbiro opened this issue Dec 10, 2024 · 2 comments

Comments

@agostbiro
Copy link
Member

Definition of Done

Remove the bail_on_(call|transaction)_failure from EDR as this should be handled by Hardhat. It was originally added as a performance optimization to EDR, but it makes the code error prone and none of the repos that we run automated benchmarks use it.

Move computation that happens when this flag is set to stack trace generation to support lazy stack trace generation from Hardhat.

@agostbiro agostbiro added this to EDR Dec 10, 2024
@github-project-automation github-project-automation bot moved this to Unconfirmed in EDR Dec 10, 2024
@agostbiro agostbiro moved this from Unconfirmed to Todo in EDR Dec 10, 2024
@iosh
Copy link

iosh commented Dec 15, 2024

Can i do this? It juse remove bail_on_(call|transaction)_failure and all related code ?
If I can do this, could you provide more information? Otherwise, just ignore me.

@agostbiro
Copy link
Member Author

Hey @iosh thanks for your interest and sorry for my late answer. Yes, you could do it, but I have to finish #734 first. Will post more info here once that's done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

2 participants