Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pantheon: no wallpapers #100293

Closed
davidak opened this issue Oct 12, 2020 · 4 comments
Closed

Pantheon: no wallpapers #100293

davidak opened this issue Oct 12, 2020 · 4 comments
Labels
0.kind: bug Something is broken 6.topic: pantheon The Pantheon desktop environment

Comments

@davidak
Copy link
Member

davidak commented Oct 12, 2020

Describe the bug

Screenshot from 2020-10-07 15-38-20

To Reproduce
Steps to reproduce the behavior:

  1. ...
  2. ...
  3. ...

Expected behavior
have wallpapers like before. this is a regression

Additional context
Add any other context about the problem here.

Notify maintainers
@worldofpeace

Metadata

  • system: "x86_64-linux"
  • host os: Linux 5.8.13, NixOS, 20.09beta992.7badbf18c45 (Nightingale)
  • multi-user?: yes
  • sandbox: yes
  • version: nix-env (Nix) 2.3.7
  • channels(root): "home-manager-20.09, nixos-20.09beta992.7badbf18c45, nixos-hardware, nixos-unstable-21.03pre246062.420f89ceb26"
  • nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos
    Maintainer information:
# a list of nixpkgs attributes affected by the problem
attribute:
# a list of nixos modules affected by the problem
module:
@davidak davidak added the 0.kind: bug Something is broken label Oct 12, 2020
@veprbl veprbl added the 6.topic: pantheon The Pantheon desktop environment label Oct 12, 2020
@worldofpeace
Copy link
Contributor

I can reproduce. This is a bug in application, probably. I changed how this plugin collects wallpapers a while ago, and that was for it to pickup a background directory from XDG_DATA_DIRS. There was one regression that got a committed fix as well. Last time I checked it seemed to work, maybe it was because it copied system backgrounds locally and making thumbnails for those was the only thing that worked on our setup. Anyways we should forward it upstream.

@worldofpeace
Copy link
Contributor

Actually, if I revert 5100e4f it works. This is a regression within the plugin for something that was fixed but seems to have broken again. The situation is that, before that commit /run/current-system/sw/share/backgrounds is just a single folder with images. After it has a nixos folder in it. elementary/switchboard-plug-pantheon-shell#157

@worldofpeace worldofpeace mentioned this issue Oct 12, 2020
Open
3 tasks
@worldofpeace
Copy link
Contributor

reported elementary/switchboard-plug-pantheon-shell#246. Maybe my change caused this, will bisect.

worldofpeace added a commit that referenced this issue Oct 26, 2020
@worldofpeace
Revert "nixos/pantheon: install nixos wallpaper"
1c46527 
This reverts commit 5100e4f.

Fixes #100293
Though it's only a workaround for now.
See elementary/switchboard-plug-pantheon-shell#246 (comment)
We trigger the broken scenario where we have two subdirectories. Reverting
that commit undoes this.

(cherry picked from commit ace69f7)
@worldofpeace
Copy link
Contributor

It was fairly involved but I figured out what a workaround for now would be elementary/switchboard-plug-pantheon-shell#246 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0.kind: bug Something is broken 6.topic: pantheon The Pantheon desktop environment
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@davidak @veprbl @worldofpeace