Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading "please retry" message when checks are pending #127

Open
sersorrel opened this issue Nov 4, 2024 · 1 comment
Open

Misleading "please retry" message when checks are pending #127

sersorrel opened this issue Nov 4, 2024 · 1 comment

Comments

@sersorrel
Copy link

When a check is still pending, the bot will tell you to try again later:

msg = "One or more checks are still pending, please retry after they are done. darwin checks can be ignored."

but it's stated in the nixpkgs README (see NixOS/nixpkgs#305553) that the bot "patiently waits for ofBorg to finish before attempting the merge again".

If the bot will in fact automatically retry the merge once checks are done, the message should probably say something closer to:

One or more checks are still pending, will automatically retry after they are done (darwin checks are ignored).

@Mic92
Copy link
Member

Mic92 commented Nov 4, 2024

At least in theory. I heard in some cases that retry doesn't work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants