Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Errors in Precis Implementation #3

Open
justinba1010 opened this issue Jul 23, 2019 · 1 comment
Open

Errors in Precis Implementation #3

justinba1010 opened this issue Jul 23, 2019 · 1 comment
Labels
bug Something isn't working help wanted Extra attention is needed priority

Comments

@justinba1010
Copy link

Currently we generate tests off of @byllyfish/precis_i18n including their original golden.json. The additional 40,000 tests were added to golden.json. We are missing around 2.5% of the comparisons. At the very least, it would be very helpful to know why, if not patch those issues.

Test Suites: 2 failed, 2 passed, 4 total
Tests:       1025 failed, 42276 passed, 43301 total
Snapshots:   0 total
Time:        101.394s
@justinba1010 justinba1010 added the bug Something isn't working label Jul 23, 2019
@justinba1010 justinba1010 mentioned this issue Jul 23, 2019
Open
@justinba1010
Copy link
Author 

Test Suites: 1 failed, 3 passed, 4 total
Tests:       961 failed, 42340 passed, 43301 total
Snapshots:   0 total
Time:        51.514s, estimated 52s

@justinba1010 justinba1010 added help wanted Extra attention is needed priority labels Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working help wanted Extra attention is needed priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@justinba1010