Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement an interceptor for Apache's HttpAsyncClient #124

Open
kedev opened this issue Oct 6, 2020 · 0 comments
Open

Implement an interceptor for Apache's HttpAsyncClient #124

kedev opened this issue Oct 6, 2020 · 0 comments

Comments

@kedev
Copy link

kedev commented Oct 6, 2020

The wingtips-apache-http-client library contains an interceptors for the HttpClient. While the interceptors implement the interfaces necessary for Apache's HttpAsyncClient, they work properly in the async client.

The existing WingtipsApacheHttpClientInterceptor starts new subspans via the request interceptor on the current thread (from which the request is executed) but when the response is handled, the async client executes the response interceptor on a different thread. This causes the subspan to never be closed and produces errors when the parent span is finalized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant