Skip to content

Commit 3d45926

Browse files
authored
fix(cli): make ts-node as an optional peer dependency (web-infra-dev#2231)
1 parent 0909f15 commit 3d45926

File tree

4 files changed

+27
-17
lines changed

4 files changed

+27
-17
lines changed

.changeset/young-paws-join.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@rspack/cli": patch
3+
---
4+
5+
make ts-node as an optional peer dependency

packages/rspack-cli/package.json

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,12 @@
3030
"ts-node": "10.9.1"
3131
},
3232
"peerDependencies": {
33-
"ts-node": "10.9.1"
33+
"ts-node": ">= 10"
34+
},
35+
"peerDependenciesMeta": {
36+
"ts-node": {
37+
"optional": true
38+
}
3439
},
3540
"dependencies": {
3641
"@discoveryjs/json-ext": "^0.5.7",

packages/rspack-cli/tests/build/typescript/rspack.config.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@ const config = {
55
entry: "./main.ts",
66
output: {
77
path: path.resolve(__dirname, "dist"),
8-
filename: "foo.bundle.js",
9-
},
8+
filename: "foo.bundle.js"
9+
}
1010
};
1111

1212
export = config;

packages/rspack-cli/tests/build/typescript/typescript.test.ts

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -3,24 +3,24 @@ import { existsSync } from "fs";
33
import { resolve } from "path";
44

55
describe("webpack cli", () => {
6-
it("should support default config in typescript", async () => {
7-
const { exitCode, stderr, stdout } = await run(__dirname, []);
6+
it("should support default config in typescript", async () => {
7+
const { exitCode, stderr, stdout } = await run(__dirname, []);
88

9-
expect(stderr).toBeFalsy();
10-
expect(stdout).toBeTruthy();
11-
expect(exitCode).toBe(0);
12-
expect(existsSync(resolve(__dirname, "dist/foo.bundle.js"))).toBeTruthy();
13-
});
9+
expect(stderr).toBeFalsy();
10+
expect(stdout).toBeTruthy();
11+
expect(exitCode).toBe(0);
12+
expect(existsSync(resolve(__dirname, "dist/foo.bundle.js"))).toBeTruthy();
13+
});
1414

15-
it("should support specifying config in typescript", async () => {
16-
const { exitCode, stderr, stdout } = await run(__dirname, [
15+
it("should support specifying config in typescript", async () => {
16+
const { exitCode, stderr, stdout } = await run(__dirname, [
1717
"-c",
1818
"./rspack.config.ts"
1919
]);
2020

21-
expect(stderr).toBeFalsy();
22-
expect(stdout).toBeTruthy();
23-
expect(exitCode).toBe(0);
24-
expect(existsSync(resolve(__dirname, "dist/foo.bundle.js"))).toBeTruthy();
25-
});
21+
expect(stderr).toBeFalsy();
22+
expect(stdout).toBeTruthy();
23+
expect(exitCode).toBe(0);
24+
expect(existsSync(resolve(__dirname, "dist/foo.bundle.js"))).toBeTruthy();
25+
});
2626
});

0 commit comments

Comments
 (0)