Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Spike-width computation #516

Open
E4-IMN opened this issue Sep 14, 2022 · 1 comment
Open

[Bug] Spike-width computation #516

E4-IMN opened this issue Sep 14, 2022 · 1 comment
Labels
bug Indicates an unexpected problem or unintended behavior

Comments

@E4-IMN
Copy link

E4-IMN commented Sep 14, 2022

Describe the bug
A colleague and I realized that the waveform_width function doesn't work well for recordings where the action potential is a upward deflection and then a downward one because the code looks for the trough first, then to the next peak.

image

Therefore, we would suggest having an extension of the function which is flexible to the 2 possible scenarios (trough to peak or peak to trough).

@rsankar9 feel free to expand on this explanation!

Environment

  • OS (e.g., Linux): Windows and Mac
  • How you installed elephant (conda, pip, source): pip
  • Python version: 3.9
  • neo python package version: 0.10.0
  • elephant python package version: 0.10.0
@Moritz-Alexander-Kern Moritz-Alexander-Kern added the bug Indicates an unexpected problem or unintended behavior label Sep 16, 2022
@Moritz-Alexander-Kern
Copy link
Member

Hello @E4-IMN ,

thanks a lot for reporting this.

Looking at the provided plot I agree with you.
Are you already working on an extension ?

In any case, the development of an extension to this function could benefit from some examples to reproduce the behavior shown above. In case you have some more examples, please do not hesitate to share.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Development

No branches or pull requests

2 participants