You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
A colleague and I realized that the waveform_width function doesn't work well for recordings where the action potential is a upward deflection and then a downward one because the code looks for the trough first, then to the next peak.
Therefore, we would suggest having an extension of the function which is flexible to the 2 possible scenarios (trough to peak or peak to trough).
@rsankar9 feel free to expand on this explanation!
Environment
OS (e.g., Linux): Windows and Mac
How you installed elephant (conda, pip, source): pip
Python version: 3.9
neo python package version: 0.10.0
elephant python package version: 0.10.0
The text was updated successfully, but these errors were encountered:
Looking at the provided plot I agree with you.
Are you already working on an extension ?
In any case, the development of an extension to this function could benefit from some examples to reproduce the behavior shown above. In case you have some more examples, please do not hesitate to share.
Describe the bug
A colleague and I realized that the waveform_width function doesn't work well for recordings where the action potential is a upward deflection and then a downward one because the code looks for the trough first, then to the next peak.
Therefore, we would suggest having an extension of the function which is flexible to the 2 possible scenarios (trough to peak or peak to trough).
@rsankar9 feel free to expand on this explanation!
Environment
conda
,pip
, source): pipneo
python package version: 0.10.0elephant
python package version: 0.10.0The text was updated successfully, but these errors were encountered: