Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support non-local file access #367

Open
palemieux opened this issue Jun 13, 2024 · 1 comment
Open

Support non-local file access #367

palemieux opened this issue Jun 13, 2024 · 1 comment
Assignees
Milestone

Comments

@palemieux
Copy link
Collaborator

The current use of the java.io.file API in IMPAnalyzer significantly limits the use of the library. In particular, it requires the IMF to be available on the local filesystem, which is not always possible/practical, e.g., on AWS lambda.

Two options come to mind:

@palemieux palemieux changed the title Move to nio2 API Support non-local file access Jun 13, 2024
@danielhdz13-netflix
Copy link
Contributor

Remote byte access is a high-value add for Photon, and we acknowledge the pain point of java.io.file not just in IMPAnalyzer, but across the library. Netflix is interested in solving this problem by adding remote-file access capabilities.

Regarding the existing S3 support pull request, we have identified several improvements that would be needed before merging. We will add a more detailed review in the PR, but they mostly revolve around backward-compatibility and leaky abstractions. We actually prefer the Java NIO-based approach - this way, Photon can focus on doing what it does best while delegating S3 byte access to another component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants