-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove joda time dependency from maestro-common #25
Comments
Hi @jun-he , I'd like to take on this task of removing the Joda-Time dependency from the maestro-common module. Could you please assign this issue to me? Additionally, I would like to clarify a few points: Are there any specific parts of the codebase that have critical dependencies on Joda-Time, which I should be particularly careful about? |
- Removed Joda-Time dependency from the Defaults class and replaced it with java.time.ZoneId. - Updated TriggerHelper class to use java.time.ZoneId instead of Joda-Time's DateTimeZone. - Simplified TimeZoneValidator to use a static final set of available time zone IDs, ensuring efficient validation.
Please review the changes related to the removal of the Joda-Time dependency from the Thank you! |
Found a similar issue in Here is the relevant code snippet for the request body of the "Create a sample workflow" API: {
"params": {
"foo": {
"expression": "new DateTime(1569018000000).withZone(DateTimeZone.forID('UTF')).monthOfYear().getAsText();",
"type": "STRING"
}
}
} |
APIs are working fine, we can create an issue for the removal of joda time from netflix-sel |
@pranaybattu thanks for the contribution! Yes, SEL also uses it and it needs some big changes to move away from it. Basically, we have to implement those SEL method using Java time libraries than Joda. |
I created a new issue for that: #61 |
- Removed Joda-Time dependency from the Defaults class and replaced it with java.time.ZoneId. - Updated TriggerHelper class to use java.time.ZoneId instead of Joda-Time's DateTimeZone. - Simplified TimeZoneValidator to use a static final set of available time zone IDs, ensuring efficient validation.
as it has been deprecated for a long time.
The text was updated successfully, but these errors were encountered: