Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Support scalar parsing in GraphQL Client response #1702

Open
srinivasankavitha opened this issue Nov 7, 2023 · 0 comments
Open
Assignees
Labels
enhancement New feature or request investigate

Comments

@srinivasankavitha
Copy link
Contributor

srinivasankavitha commented Nov 7, 2023

When we serialize requests, we pass in a map of the scalar so those will be serialized using the appropriate scalar implementation as done here.

However, on the response side, we don't use the scalar deserialize logic but instead defer to the Jackson object mapper, which is incorrect.

This can lead to incorrect deserialized values.

@srinivasankavitha srinivasankavitha added the enhancement New feature or request label Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request investigate
Projects
None yet
Development

No branches or pull requests

3 participants