Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Extract interface from DefaultDgsGraphQLContextBuilder #1259

Open
nallwhy opened this issue Oct 4, 2022 · 3 comments
Open

feature: Extract interface from DefaultDgsGraphQLContextBuilder #1259

nallwhy opened this issue Oct 4, 2022 · 3 comments
Labels
enhancement New feature or request stale

Comments

@nallwhy
Copy link

nallwhy commented Oct 4, 2022

Describe the Feature Request

To support multiple custom contexts, changing DefaultDgsGraphQLContextBuilder with another class should be available.

Describe Preferred Solution

For that, DgsGraphQLContextBuilder interface should be made and many codes that depend on DefaultDgsGraphQLContextBuilder should depend on DgsGraphQLContextBuilder interface.

It meansDefaultDgsGraphQLContextBuilder became a just one of implementation of DgsGraphQLContextBuilder.

Describe Alternatives

I have no idea.

@nallwhy nallwhy added the enhancement New feature or request label Oct 4, 2022
@nallwhy nallwhy changed the title feature: Replace DefaultDgsGraphQLContextBuilder with DgsGraphQLContextBuilder interface feature: Extract interface from DefaultDgsGraphQLContextBuilder Oct 4, 2022
@nallwhy
Copy link
Author

nallwhy commented Oct 4, 2022

If this idea is OK, I can contribute to it.

@srinivasankavitha
Copy link
Contributor

I'm not sure I understand the use case. You can already build a custom context using the context builder. I don't quite see the need for a different implementation of the DefaultDgsGraphQLContextBuilder.

@nallwhy
Copy link
Author

nallwhy commented Oct 5, 2022

Can I build multiple custom context with DefaultDgsGraphQLContextBuilder? As I know, graphql-java supports multiple custom context.

ex) AuthContext, DeviceContext, ...

@github-actions github-actions bot added the stale label Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stale
Projects
None yet
Development

No branches or pull requests

2 participants