Skip to content
This repository was archived by the owner on Dec 13, 2023. It is now read-only.

Commit 825f15f

Browse files
update workflow before creating/updating task for retry/rerun
1 parent 5b52527 commit 825f15f

File tree

1 file changed

+12
-11
lines changed

1 file changed

+12
-11
lines changed

core/src/main/java/com/netflix/conductor/core/execution/WorkflowExecutor.java

+12-11
Original file line numberDiff line numberDiff line change
@@ -421,10 +421,10 @@ public void retry(String workflowId) {
421421
}
422422
});
423423

424-
scheduleTask(workflow, rescheduledTasks);
425-
426424
workflow.setStatus(WorkflowStatus.RUNNING);
427425
executionDAOFacade.updateWorkflow(workflow);
426+
427+
scheduleTask(workflow, rescheduledTasks);
428428
executionDAOFacade.updateTasks(workflow.getTasks());
429429

430430
decide(workflowId);
@@ -1236,6 +1236,16 @@ private boolean rerunWF(String workflowId, String taskId, Map<String, Object> ta
12361236
}
12371237

12381238
if (rerunFromTask != null) {
1239+
// set workflow as RUNNING
1240+
workflow.setStatus(WorkflowStatus.RUNNING);
1241+
if (correlationId != null) {
1242+
workflow.setCorrelationId(correlationId);
1243+
}
1244+
if (workflowInput != null) {
1245+
workflow.setInput(workflowInput);
1246+
}
1247+
executionDAOFacade.updateWorkflow(workflow);
1248+
12391249
// Remove all tasks after the "rerunFromTask"
12401250
for (Task task : workflow.getTasks()) {
12411251
if (task.getSeq() > rerunFromTask.getSeq()) {
@@ -1256,15 +1266,6 @@ private boolean rerunWF(String workflowId, String taskId, Map<String, Object> ta
12561266
rerunFromTask.setExecuted(false);
12571267
executionDAOFacade.updateTask(rerunFromTask);
12581268

1259-
// and set workflow as RUNNING
1260-
workflow.setStatus(WorkflowStatus.RUNNING);
1261-
if (correlationId != null) {
1262-
workflow.setCorrelationId(correlationId);
1263-
}
1264-
if (workflowInput != null) {
1265-
workflow.setInput(workflowInput);
1266-
}
1267-
executionDAOFacade.updateWorkflow(workflow);
12681269
decide(workflowId);
12691270
return true;
12701271
}

0 commit comments

Comments
 (0)